Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL] Rename Plugin object -> Adapter. #15363

Merged
merged 5 commits into from
Sep 23, 2024
Merged

[SYCL] Rename Plugin object -> Adapter. #15363

merged 5 commits into from
Sep 23, 2024

Conversation

aarongreig
Copy link
Contributor

@aarongreig aarongreig commented Sep 11, 2024 •
edited
Loading

Also fix a few references to "plugin" in source files and a unittest script.

@aarongreig
[SYCL] Rename Plugin object -> Adapter.
936dd1f 
Also fix a few references to "plugin" in source files and a unittest
script.
@aarongreig aarongreig marked this pull request as ready for review September 12, 2024 15:14
@aarongreig aarongreig requested review from a team as code owners September 12, 2024 15:14
@aarongreig aarongreig mentioned this pull request Sep 12, 2024
Open
isaacault
isaacault approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@isaacault isaacault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sycl/source/detail/bindless_images.cpp LGTM.

@aarongreig
Copy link
Contributor Author

@intel/llvm-gatekeepers please merge

@aarongreig
Copy link
Contributor Author

ack, didn't notice there's still a required review never mind

@aarongreig
Copy link
Contributor Author

@intel/llvm-gatekeepers please merge

@martygrant martygrant merged commit 5cd9de1 into intel:sycl Sep 23, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RossBrunton RossBrunton RossBrunton approved these changes

@kbenzie kbenzie kbenzie approved these changes

@Bensuo Bensuo Bensuo approved these changes

@cppchedy cppchedy cppchedy approved these changes

@isaacault isaacault isaacault approved these changes

@sergey-semenov sergey-semenov sergey-semenov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@aarongreig @RossBrunton @kbenzie @Bensuo @cppchedy @isaacault @sergey-semenov @martygrant