[SYCL] Add work-around for event leak in profiling tag #14985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to a bug in the L0 UR adapter, the profiling tag extension leaks UR events on out-of-order queues. This is not due to the profiling tag events themselves, but rather due to the need for a barrier enforcing correct ordering of the inserted tag. Since the barrier ensures completion prior to the profiling tag executing, the output event is not needed, but the L0 adapter leaks the event if no output event is specified. To combat this, this work-around passes an output event and immediately frees it after the barrier has been submitted. See oneapi-src/unified-runtime#1947. Signed-off-by: Larsen, Steffen <[email protected]>
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
againull
approved these changes
Aug 7, 2024
|
Timeout in Graph/RecordReplay/usm_fill.cpp has been reported in #15000. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a bug in the L0 UR adapter, the profiling tag extension leaks UR events on out-of-order queues. This is not due to the profiling tag events themselves, but rather due to the need for a barrier enforcing correct ordering of the inserted tag. Since the barrier ensures completion prior to the profiling tag executing, the output event is not needed, but the L0 adapter leaks the event if no output event is specified. To combat this, this work-around passes an output event and immediately frees it after the barrier has been submitted.
See oneapi-src/unified-runtime#1947.