Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update profiles for test #274

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update profiles for test #274

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions test/test_data.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,20 @@ static const Profiles g_vaProfiles = {
VAProfileVP9Profile1,
VAProfileVP9Profile2,
VAProfileVP9Profile3,
VAProfileHEVCMain12,
VAProfileHEVCMain422_10,
VAProfileHEVCMain422_12,
VAProfileHEVCMain444,
VAProfileHEVCMain444_10,
VAProfileHEVCMain444_12,
VAProfileHEVCSccMain,
VAProfileHEVCSccMain10,
VAProfileHEVCSccMain444,
VAProfileAV1Profile0,
VAProfileAV1Profile1,
VAProfileHEVCSccMain444_10,
VAProfileProtected,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greetings team,

Was browsing through the tests and noticed this PR. Here are some comments to hopefully push it forward.

Seems like this should be split in three patches and enhanced as follows:

  • the HEVC entries should also be added to g_vaHEVCProfiles just below
  • VAProfileAV1Profile0 and VAProfileAV1Profile1 should be added to g_vaAV1Profiles, which then ought to be used in the respective tests
  • VAProfileProtected - same comments as AV1 apply

Hope that helps o/


};

static const Profiles g_vaNoneProfiles = {
Expand Down