e2e: update e2e tests to use -label-filter #1866
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hj-johannes-lee
requested review from
mythi,
bart0sh,
ozhuraki,
kad and
tkatila
as code owners
hj-johannes-lee
force-pushed
the
PR-2024-009
branch
5 times, most recently
from
c07fb82
to
a602228
Compare
Current system with FOCUS and SKIP is complicated. Introduce label filter, update plain text labels of e2e tests to ginkgo>Label(), and update Makefile. In addition, put labels to admission webhooks for fpga and sgx. Signed-off-by: Hyeongju Johannes Lee <[email protected]>
hj-johannes-lee
force-pushed
the
PR-2024-009
branch
from
a602228
to
c2a509a
Compare
tkatila
reviewed
Oct 14, 2024
| @@ -189,7 +189,7 @@ func describe() { | |||
| framework.Logf("found card and renderD from the log") | |||
| }) | |||
|
|
|||
| ginkgo.Context("When [Deployment:monitoring] deployment is applied [Resource:i915]", func() { | |||
| ginkgo.Context("When [Deployment:monitoring] deployment is applied", ginkgo.Label("Resource:i915"), func() { | |||
There was a problem hiding this comment.
Deployment:monitoring should also be converted into a label.
tkatila
reviewed
Oct 14, 2024
| @@ -200,13 +200,13 @@ func describe() { | |||
| }) | |||
| }) | |||
|
|
|||
| ginkgo.Context("When [Deployment:healthManagement] deployment is applied [Resource:i915]", func() { | |||
| ginkgo.Context("When [Deployment:healthManagement] deployment is applied", ginkgo.Label("Resource:i915"), func() { | |||
There was a problem hiding this comment.
ditto for Deployment:healthManagement
tkatila
reviewed
Oct 14, 2024
| ginkgo.It("check if i915 resources is available", func(ctx context.Context) { | ||
| createPluginAndVerifyExistence(f, ctx, healthMgmtPath, "gpu.intel.com/i915") | ||
| }) | ||
| }) | ||
|
|
||
| ginkgo.Context("When [Deployment:resourceManager] deployment is applied [Resource:i915]", func() { | ||
| ginkgo.Context("When [Deployment:resourceManager] deployment is applied", ginkgo.Label("Resource:i915"), func() { |
There was a problem hiding this comment.
and for ditto for Deployment:resourceManager
tkatila
reviewed
Oct 14, 2024
There was a problem hiding this comment.
Some suggestions or thoughts:
- As we don't have to regex items from long strings anymore, we could drop prefixes like "Device:". The label is "fpga" or "qat", adding the "Device:" prefix doesn't add anything imo.
** Same could be done for the "App:" but I'm ok to keep it there. - Could we drop the "NoApp"? I'm not sure myself, but would like to entertain the idea. :)
Are you verifying that the tests stay the same with the changes? i.e. running with dry-run?
Also, sadly, using the labels doesn't make it much more readable. It's still quite bad.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #1862
Current system with FOCUS and SKIP is complicated. Introduce label filter, update plain text labels of e2e tests to ginkgo.Label(), and update Makefile.
In addition, put labels to admission webhooks for fpga and sgx.