-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc updates #1384
Doc updates #1384
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1384 +/- ##
=======================================
Coverage 50.89% 50.89%
=======================================
Files 44 44
Lines 4985 4985
=======================================
Hits 2537 2537
Misses 2302 2302
Partials 146 146 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
small nit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general, main thing is moving "Use Cases for Different Modes" to where the related CLI options are documented.
"Fixes:" syntax differs between commits, in one the issue number is missing '#'. |
I think this is fine for merging (with or without the last trivial fine-tuning comments to my earlier suggestions). |
69c9fe3
to
a2db2e3
Compare
Fixes: intel#1059 Signed-off-by: Tuomas Katila <[email protected]>
Fixes: intel#1132 Co-authored-by: Eero Tamminen <[email protected]> Signed-off-by: Tuomas Katila <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@uniemimu to merge
Fixes: intel#1381 Co-authored-by: Eero Tamminen <[email protected]> Signed-off-by: Tuomas Katila <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Updates for documentation from #1045.
Fixes: #1381
Fixes: #1132
Fixes: #1059