-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade to k8s 1.25.0 #1131
Merged
Merged
upgrade to k8s 1.25.0 #1131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1131 +/- ##
=======================================
Coverage 52.96% 52.96%
=======================================
Files 40 40
Lines 4358 4358
=======================================
Hits 2308 2308
Misses 1923 1923
Partials 127 127 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
bart0sh
force-pushed
the
PR145-upgrade-to-k8s-1.25.0
branch
from
September 1, 2022 13:21
f61430f
to
39dfa55
Compare
mythi
reviewed
Sep 1, 2022
mythi
reviewed
Sep 1, 2022
- added helper script from kubernetes/kubernetes#79384 (comment) to scripts/upgrade-k8s.sh - removed bashisms from the script Signed-off-by: Ed Bartosh <[email protected]>
- upgraded to Kubernetes 1.25.0: $ ./scripts/upgrade-k8s.sh 1.25.0 go: downloading k8s.io/kubernetes v1.25.0 go: upgraded k8s.io/api v0.25.0-rc.0 => v0.25.0 go: upgraded k8s.io/apimachinery v0.25.0-rc.0 => v0.25.0 go: upgraded k8s.io/apiserver v0.25.0-rc.0 => v0.25.0 go: upgraded k8s.io/component-base v0.25.0-rc.0 => v0.25.0 go: upgraded k8s.io/component-helpers v0.25.0-rc.0 => v0.25.0 go: upgraded k8s.io/kubernetes v1.25.0-rc.0 => v1.25.0 Signed-off-by: Ed Bartosh <[email protected]>
bart0sh
force-pushed
the
PR145-upgrade-to-k8s-1.25.0
branch
from
September 1, 2022 21:08
39dfa55
to
ad58ba4
Compare
Removed unused import. This should fix this golangci-lint failure: can't run linter goanalysis_metalinter: buildir: failed to load package : could not load export data: no export data for "cloud.google.com/go/compute/metadata" Signed-off-by: Ed Bartosh <[email protected]>
mythi
approved these changes
Sep 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @bart0sh!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from 'unknown revision v0.0.0' errors, seemingly due to 'require k8s.io/foo v0.0.0' kubernetes/kubernetes#79384 (comment)
to scripts/upgrade-k8s.sh
as requested
removed bashisms from the script
upgraded to Kubernetes 1.25.0:
$ ./scripts/upgrade-k8s.sh 1.25.0
go: downloading k8s.io/kubernetes v1.25.0
go: upgraded k8s.io/api v0.25.0-rc.0 => v0.25.0
go: upgraded k8s.io/apimachinery v0.25.0-rc.0 => v0.25.0
go: upgraded k8s.io/apiserver v0.25.0-rc.0 => v0.25.0
go: upgraded k8s.io/component-base v0.25.0-rc.0 => v0.25.0
go: upgraded k8s.io/component-helpers v0.25.0-rc.0 => v0.25.0
go: upgraded k8s.io/kubernetes v1.25.0-rc.0 => v1.25.0
Signed-off-by: Ed Bartosh [email protected]