Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve e2e labels matters #1862

Open
3 tasks
hj-johannes-lee opened this issue Oct 1, 2024 · 0 comments · May be fixed by #1866
Open
3 tasks

Improve e2e labels matters #1862

hj-johannes-lee opened this issue Oct 1, 2024 · 0 comments · May be fixed by #1866

Comments

@hj-johannes-lee
Copy link
Contributor

We currently have plain text form labels and that is not supported by -label-filter.
Since -label-filter looks cleaner and straightforward than mixing -focus and -skip, it is required to change as follows if we want to use -label-filter.

  • update test/e2e/<dev>/<dev>.go files to use ginkgo.Label() instead of plain text.
  • update Makefile to use -label-filter
  • update .github/workflows/lib-e2e.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

e2e: update e2e tests to use -label-filter hj-johannes-lee/intel-device-plugins-for-kubernetes
1 participant
@hj-johannes-lee