Skip to content

Commit

Permalink
Squash to "selftests: mptcp: pm_nl_ctl: always look for errors"
Browse files Browse the repository at this point in the history
mptcp_join.sh selftest tries to add a bad endpoint on purpose ("ID
change is prevented") so it is normal to see this error:

   114 implicit EP
         creation                            [ ok ]
         mptcp_info subflows=1:1             [ ok ]
         mptcp_info add_addr=1:1             [ ok ]
   netlink error -22 (Invalid argument)
   ./pm_nl_ctl: bailing out due to netlink error[s]
         ID change is prevented              [ ok ]
         modif is allowed                    [ ok ]

We can mute the output because we expect an error.

We also need to edit the commit message to mention mptcp_join.sh
selftest also need to be modified, not just pm_netlink.sh.

Signed-off-by: Matthieu Baerts <[email protected]>
  • Loading branch information
matttbe authored and intel-lab-lkp committed Jul 28, 2023
1 parent 7ba82a6 commit 01da350
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tools/testing/selftests/net/mptcp/mptcp_join.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3454,7 +3454,7 @@ endpoint_tests()
chk_mptcp_info subflows 1 subflows 1
chk_mptcp_info add_addr_signal 1 add_addr_accepted 1

pm_nl_add_endpoint $ns2 10.0.2.2 id 33
pm_nl_add_endpoint $ns2 10.0.2.2 id 33 2>/dev/null
pm_nl_check_endpoint "ID change is prevented" \
$ns2 10.0.2.2 id 1 flags implicit

Expand Down

0 comments on commit 01da350

Please sign in to comment.