Skip to content
This repository has been archived by the owner on Apr 24, 2023. It is now read-only.

Broker improvements api updates #24

Merged
merged 3 commits into from
Dec 12, 2018
Merged

Conversation

sedroche
Copy link
Contributor

@sedroche sedroche commented Nov 29, 2018

Motivation

Re: This comment
There is some refactoring and bug fixes that were in a couple of branches. See => #9 and #19 so this PR aggregates them all.
(The commits from #19 is all the non ManagedServiceNamespace stuff)

What

  • README updates for tests
  • Match the service broker API spec for handling errors, naming etc.
  • Simplified the APIs as we kept adding parameters which was getting unmanageable.
  • Test suite updates
  • Update fuse deployer lastOperation to work from the fuse CR instead of pods

Verification Steps

https://github.com/integr8ly/managed-service-broker/tree/broker-improvements-api-updates#integration-tests

I will rebase #19 and close #9 once this lands

For Gone responses the Platform MUST consider this response a success and forget about the resource.
Currently the platform never stops polling for missing resources. This should clean up the logs etc.
@sedroche sedroche force-pushed the broker-improvements-api-updates branch from 5f2977b to 8635a57 Compare December 7, 2018 13:28
@sedroche
Copy link
Contributor Author

sedroche commented Dec 7, 2018

@maleck13 Can this be merged? It needs constant rebasing since it contains API changes etc.

Code has been reviewed in #9 and #19 as per the PR description

@sedroche sedroche merged commit aa15be2 into master Dec 12, 2018
@sedroche sedroche deleted the broker-improvements-api-updates branch December 12, 2018 15:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant