[DDW-1023] Add Search Icon to Input Component #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawnbusuttil
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is meant to streamline how we apply search icon within consumers of the library.
What does this mean?
Currently, apps such as Daedalus are getting the search icon used in text fields from two different places: React Polymorph and the Daedalus assets folder itself. This PR adds a
hasSearchboolean to existingInputSkinso that when set totruerenders a search icon at the start of the text field. Therefore, enabling us to get the icon from Polymorph only, promoting reuse and avoiding chaos when styling/changing opacity.All changes are strictly for developer use only and are not intended to change anything visual in the UI.