Skip to content

Commit

Permalink
using angular.equals for checking selected class. closes #8
Browse files Browse the repository at this point in the history
  • Loading branch information
bianchimro committed Jan 3, 2016
1 parent e5dc87b commit e8d9d5e
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 5 deletions.
8 changes: 6 additions & 2 deletions dist/ionic-modal-select.js
Original file line number Diff line number Diff line change
Expand Up @@ -61,14 +61,14 @@ var modalSelectTemplates = modalSelectTemplates || {};modalSelectTemplates['moda
' </p>\n' +
' </div>\n' +
' <div class="list" ng-if="showList" class="animate-if">\n' +
' <div class="item item-text-wrap" collection-repeat="option in options track by $index" ng-click="setOption(option)" ng-class="{\'{{::ui.selectedClass}}\': getSelectedValue(option) == ui.value}"> \n' +
' <div class="item item-text-wrap" collection-repeat="option in options track by $index" ng-click="setOption(option)" ng-class="{\'{{::ui.selectedClass}}\': compareValues(getSelectedValue(option), ui.value) }"> \n' +
' <div compile="inner" compile-once="true"></div>\n' +
' </div>\n' +
' </div>\n' +
' </div>\n' +
' <div ng-if="ui.shortList">\n' +
' <div class="list">\n' +
' <div class="item item-text-wrap" ng-repeat="option in options track by $index" ng-click="setOption(option)" ng-class="{\'{{::ui.selectedClass}}\': getSelectedValue(option) == ui.value}">\n' +
' <div class="item item-text-wrap" ng-repeat="option in options track by $index" ng-click="setOption(option)" ng-class="{\'{{::ui.selectedClass}}\': compareValues(getSelectedValue(option), ui.value) }">\n' +
' <div compile="inner" compile-once="true"></div>\n' +
' </div>\n' +
' </div>\n' +
Expand Down Expand Up @@ -243,6 +243,10 @@ angular.module('ionic-modal-select', [])
scope.showList = false;
});
};

scope.compareValues = function(a, b){
return angular.equals(a, b);
};

//loading the modal
var modalTpl = multiple ? 'modal-template-multiple.html' : 'modal-template.html';
Expand Down
2 changes: 1 addition & 1 deletion dist/ionic-modal-select.min.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions src/ionic-modal-select.js
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,10 @@ angular.module('ionic-modal-select', [])
scope.showList = false;
});
};

scope.compareValues = function(a, b){
return angular.equals(a, b);
};

//loading the modal
var modalTpl = multiple ? 'modal-template-multiple.html' : 'modal-template.html';
Expand Down
4 changes: 2 additions & 2 deletions src/modal-template.html
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,14 @@ <h4 class="muted">{{::ui.loadListMessage}}</h4>
</p>
</div>
<div class="list" ng-if="showList" class="animate-if">
<div class="item item-text-wrap" collection-repeat="option in options track by $index" ng-click="setOption(option)" ng-class="{'{{::ui.selectedClass}}': getSelectedValue(option) == ui.value}">
<div class="item item-text-wrap" collection-repeat="option in options track by $index" ng-click="setOption(option)" ng-class="{'{{::ui.selectedClass}}': compareValues(getSelectedValue(option), ui.value) }">
<div compile="inner" compile-once="true"></div>
</div>
</div>
</div>
<div ng-if="ui.shortList">
<div class="list">
<div class="item item-text-wrap" ng-repeat="option in options track by $index" ng-click="setOption(option)" ng-class="{'{{::ui.selectedClass}}': getSelectedValue(option) == ui.value}">
<div class="item item-text-wrap" ng-repeat="option in options track by $index" ng-click="setOption(option)" ng-class="{'{{::ui.selectedClass}}': compareValues(getSelectedValue(option), ui.value) }">
<div compile="inner" compile-once="true"></div>
</div>
</div>
Expand Down

0 comments on commit e8d9d5e

Please sign in to comment.