optimisedGlob a full drop-in-replacement of globby #2381
+392
−230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlouisse
requested review from
gerjanvangeest,
narzac,
Knorgias,
okadurin and
ryubro
as code owners
🦋 Changeset detectedLatest commit: 87dc93f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
tlouisse
changed the title
ryubro
approved these changes
Oct 18, 2024
| @@ -219,7 +238,12 @@ export async function optimisedGlob(globOrGlobs, providedOptions = {}) { | |||
| options.onlyDirectories = true; | |||
| } | |||
|
|
|||
| const globs = Array.isArray(globOrGlobs) ? Array.from(new Set(globOrGlobs)) : [globOrGlobs]; | |||
| const regularGlobs = Array.isArray(globOrGlobs) ? toUniqueArray(globOrGlobs) : [globOrGlobs]; | |||
There was a problem hiding this comment.
Did you mean to use ensureArray here?
There was a problem hiding this comment.
Also, toUniqueArray here seems not necessary as we do it anyway on L246.
tlouisse
force-pushed
the
feat/addIgnoreSupportToGlob
branch
from
3ef0b28
to
87dc93f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make optimisedGlob a full drop-in-replacement of globby by also supporting
ignore:string[]option