Apply suggestions from code review

ing-bank · Aug 28, 2024 · 7c8d8f5 · 7c8d8f5
1 parent bb3c7f3
commit 7c8d8f5
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/.changeset/avoid-growing-margin.md b/.changeset/avoid-growing-margin.md
@@ -2,4 +2,4 @@
 '@lion/ui': patch
 ---
 
-fix(2323): avoid growing margin when using overlays with tooltips
+fix: [overlays] avoid growing margin when using `preventsScroll: false`
diff --git a/packages/ui/components/overlays/src/OverlayController.js b/packages/ui/components/overlays/src/OverlayController.js
@@ -787,7 +787,7 @@ export class OverlayController extends EventTarget {
    * @protected
    */
   _keepBodySize({ phase }) {
-    if (this.placementMode !== 'global') {
+    if (!this.preventsScroll) {
       return;
     }
 

diff --git a/packages/ui/components/overlays/test/OverlayController.test.js b/packages/ui/components/overlays/test/OverlayController.test.js
@@ -1771,13 +1771,18 @@ describe('OverlayController', () => {
      */
     const overlayControllerLocal = new OverlayController({
       ...withLocalTestConfig(),
+      preventsScroll: false,
     });
 
     it('should not run with local placement', async () => {
       await overlayControllerLocal.show();
 
       expect(overlayControllerLocal.__bodyMarginRightInline).to.equal(undefined);
       expect(overlayControllerLocal.__bodyMarginRight).to.equal(undefined);
+
+      overlayControllerLocal.updateConfig({ preventsScroll: true }); 
+      expect(overlayControllerLocal.__bodyMarginRightInline).to.not.equal(undefined);
+      expect(overlayControllerLocal.__bodyMarginRight).to.not.equal(undefined);
     });
   });
 });