No headers issue #54
Open
No headers issue #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to infograf768-master
|
tks, will test later. |
|
This patch works fine here. No side effect when we need a real Not in Reference, for French for example. @yaroslaw74 |
Valc
added a commit
to Valc/jmlocalise
that referenced
this pull request
Jun 30, 2022
*- Solve "No headers" issue started at infograf768/j4localise#54 *- False positives catched as context comments issue. *- Add css to "word-break" the en-GB "key/string" to translate at regular edition mode. *- Add some "padding" using the "<br>" workarrownd beteween the keys cases to display at regular edition mode. *- Ensure than at regular edition mode will display the en-GB commnent lines presents at the file to translate when "$header" is false.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@infograf768
@yaroslaw74
Here is the first attempt trying to solve the issue that is opened here:
#53
To test, after apply this patch, i have used the shared language files without save in raw or normal edition the "en-GB" version, due seems the patch needs to work also when the en-GB file is updated.
Before the patch, editing the en-GB file and saving it in normal mode the headers was created automaticaly by com_localise code but the first string was deleted from en-GB and then displayed as "not in ref" at "ru-RU".
The issue is maninly due the reference file have no headers, and for me that one is a format issue than should send a warning message when present (not implemented at the moment but easy to do it wthin this patch) and is suggested contact with the author to ask if is posible add to the header, at least, the copyright and license info.
Please, test it and let me know if we add a warning message and how is working also testing with files with headers or real not in ref keys.
Regards,