Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(agent): Fix buffer not flushing if all metrics are written #15969

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

DStrand1
Copy link
Member

@DStrand1 DStrand1 commented Oct 2, 2024

Summary

Fixes an issue where the disk buffer would not always flush if the buffer was emptied entirely by a metric batch

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #15868

@DStrand1 DStrand1 self-assigned this Oct 2, 2024
@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Oct 2, 2024
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small simplifications...

models/buffer_disk.go Outdated Show resolved Hide resolved
models/buffer_disk.go Outdated Show resolved Hide resolved
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Oct 7, 2024

@srebhan srebhan changed the title fix(agent.buffer): Fix buffer not flushing if all metrics are written fix(agent): Fix buffer not flushing if all metrics are written Oct 7, 2024
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DStrand1, please test again and merge if you are sure the changes are OK!

@srebhan srebhan added area/agent ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. labels Oct 7, 2024
@srebhan srebhan assigned srebhan and DStrand1 and unassigned DStrand1 and srebhan Oct 7, 2024
@DStrand1 DStrand1 merged commit 7435208 into influxdata:master Oct 7, 2024
28 of 29 checks passed
@DStrand1 DStrand1 deleted the fix/15868 branch October 7, 2024 16:32
@github-actions github-actions bot added this to the v1.32.1 milestone Oct 7, 2024
srebhan pushed a commit that referenced this pull request Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/agent fix pr to fix corresponding bug ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Buffer is not flushed when buffer_strategy = "disk"
2 participants