Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing partial and schema descriptions for InfluxQL JSON response #651

Merged
merged 2 commits into from
May 17, 2024

Conversation

jstirnaman
Copy link
Contributor

@jstirnaman jstirnaman commented May 16, 2024

Closes #650, part of https://github.com/influxdata/DAR/issues/424

  • Add descriptions for InfluxQL JSON response properties.
  • Add example chunked response
  • Fix: Transfer-Encoding header to schema (for chunked responses).
  • Fix: add missing partial property to results schema.

Closes #650, part of influxdata/DAR#424

- Add descriptions for InfluxQL JSON response properties.
- Fix: `Transfer-Encoding` header to schema (for chunked responses).
- Fix: add missing `partial` property to `results` schema.
@jstirnaman jstirnaman requested a review from a team as a code owner May 16, 2024 17:40
@jstirnaman jstirnaman requested review from sanderson, mhilton, hiltontj and davidby-influx and removed request for a team May 16, 2024 17:40
jstirnaman added a commit to influxdata/docs-v2 that referenced this pull request May 16, 2024
Copy link
Contributor

@sanderson sanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@hiltontj hiltontj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I added influxdata/influxdb#25014 to make sure we are supporting the partial parameter in the Edge implementation of the v1 /query API.

Copy link

@hiltontj hiltontj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry - meant to ✅ that...

@jstirnaman jstirnaman merged commit ad26a17 into master May 17, 2024
5 checks passed
@jstirnaman jstirnaman deleted the chore/650-influxql-json-response branch May 17, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: Describe v1 InfluxQL response object schemas
3 participants