Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support partial parameter in the chunked v1 /query API response #25014

Open
hiltontj opened this issue May 17, 2024 · 0 comments · May be fixed by #25126
Open

Support partial parameter in the chunked v1 /query API response #25014

hiltontj opened this issue May 17, 2024 · 0 comments · May be fixed by #25126
Labels

Comments

@hiltontj
Copy link
Contributor

hiltontj commented May 17, 2024

See https://github.com/influxdata/openapi/pull/651/files

When the v1 /query API returns a chunked response, we should be including a partial parameter in the series results to indicate that there are more records to be streamed.

Edit: This issue is a bit more challenging than it may appear. The current buffering/streaming logic in the v1 query API code is not set up to emit such a parameter that is aware of records that have not been streamed to the response yet. This is because it currently flushes everything that has been buffered, if possible, before polling the input RecordBatchStream for more RecordBatches; in which case, the value of partial parameter may depend on record batches yet to be streamed.

Ultimately, to make this work, we likely need to change the underlying buffering/streaming logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant