debug ci #788
Closed
debug ci #788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiasdiener
commented
Oct 3, 2024
|
It seems that wjakob/nanobind#701 broke building pyopencl. Perhaps monkeypatching |
matthiasdiener
force-pushed
the
debug-ci
branch
from
c237894
to
1fad701
Compare
matthiasdiener
force-pushed
the
debug-ci
branch
from
1fad701
to
02f6918
Compare
inducer
reviewed
Oct 5, 2024
src/wrap_cl_part_2.cpp
Outdated
| @@ -32,6 +32,11 @@ | |||
|
|
|||
|
|
|||
|
|
|||
| void dummy_fn() {} | |||
| PyType_Slot slots[] = { | |||
There was a problem hiding this comment.
I think I'd prefer to just move the implementation of the constructors to C++, instead of this slots hackery.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.