Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run flake8 without an env on Github CI #702

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Conversation

inducer
Copy link
Owner

@inducer inducer commented Oct 6, 2023

In a way, this addresses
zheller/flake8-quotes#117, since it forces the Python that runs flake8 onto 'oldest supported', currently 3.8.

In a way, this addresses
zheller/flake8-quotes#117, since it forces the
Python that runs flake8 onto 'oldest supported', currently 3.8.
@inducer inducer enabled auto-merge (rebase) October 6, 2023 18:28
@inducer inducer merged commit 7658e2f into main Oct 6, 2023
17 checks passed
@inducer inducer deleted the github-ci-run-flake8-bare branch October 6, 2023 20:12
@alexfikl
Copy link
Contributor

alexfikl commented Oct 7, 2023

Why was this picking up python 3.12? The CI already sets python-version: '3.8' in the flake8 job for compatibility..

@inducer
Copy link
Owner Author

inducer commented Oct 7, 2023

That 3.8 specified the Python version installed by Github, which was shortly thereafter made moot by the conda env being installed.

@alexfikl
Copy link
Contributor

alexfikl commented Oct 7, 2023

Hmm, that's a bit confusing.. Should we do a conda env create python=$PYTHON_VERSION or something like that in ci-support?

Only pytools seems to be doing a matrix on the python-version and it uses venv directly, so that works. Most other projects try to run flake8 on python-version: '3.8' with conda and probably have the same issue as this, but it didn't complain yet..

@inducer
Copy link
Owner Author

inducer commented Oct 7, 2023

IDK. Kind of reluctant to attempt to overengineer something here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants