Add a transformation to decouple orthogonal dimensions into separate BasicSet #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaushikcfd
force-pushed
the
decouple-domain
branch
from
e2873d4
to
514bcf7
Compare
inducer
reviewed
Mar 14, 2023
| def decouple_domain(kernel: LoopKernel, | ||
| inames: Collection[str], | ||
| parent_inames: Collection[str]) -> LoopKernel: | ||
| r""" |
There was a problem hiding this comment.
Should mention that it is the inverse of loopy.loop.merge_domains. Perhaps move to loop for consistency? Also add a reference there?
inducer
reviewed
Mar 14, 2023
|
|
||
| An error is raised if all the *inames* do not correspond to the same home | ||
| domain of *kernel*. | ||
| """ |
There was a problem hiding this comment.
Should mention that this is not equivalent in the case of imperfectly nested loops.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.