Fix api options errors #29
Conversation
To speed up e2e tests and make them easier to read, since lots of files changing triggers lots of runs of the suites, and sometimes there's an error because a file is being written to when the tests run.
|
|
||
| (function () { | ||
|
|
||
| var helpers = window._helpers = window._helpers || {}; |
There was a problem hiding this comment.
Instantiates window._helpers if it's not already setup, whilst also returning the same object to helpers so it can be altered and automatically "exported" as window._helpers.
Perhaps this would read better?
var helpers = window._helpers = (window._helpers || {});
| var factoryMethods = options.factory.methods; | ||
|
|
||
|
|
||
| describe(moduleName + ': getting fields from OPTIONS request', function () { |
There was a problem hiding this comment.
We have previously found (in Python tests) that too much automation in the tests results in issues debugging the tests and understanding them. The result has been that we try to make tests as simple as possible even if involves them not being DRY.
There was a problem hiding this comment.
Looking at this replication it seems that there should be a single service that we could test with a single test that all directives use.
There was a problem hiding this comment.
Yeah, that's exactly what I was about to type: that this DRY test shows how the source can be made DRY to allow for simpler tests =D
There was a problem hiding this comment.
In other words, rather than writing DRY tests it would be better to DRY the code to a service that does something like:
(response) => response.data.actions && (response.data.actions.POST || response.data.actions.PUT)
There was a problem hiding this comment.
The test the service / factory.
There was a problem hiding this comment.
I was thinking that it would be a better task to think about what more can be service-ised, what similar concepts appear in multiple modules and thus have duplicated code.
Fix #28
@incuna/js Please merge, ta!