Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force inject witness + signature and store them with the newly created revision. #397

Closed
FantasticoFox opened this issue Jun 23, 2024 · 2 comments

Comments

@FantasticoFox
Copy link
Collaborator

FantasticoFox commented Jun 23, 2024

For correctness we need that the signature and the witness data is always injected within the content of the page to ensure that we have correctness. This is part of moving towards inblockio/aqua-improvement-proposal#2

Current state:

  • witness is stored next to the revision
  • witness does not trigger a new revision to be written into the page
    • the witness data itself is stored alongside the revision which is witnessed
  • witnessed to a test network, but not if the latest was already witnessed to mainnet).
    • signature has an option to not inject, and create no new revision
    • signature data is stored alongside the revision with is signed

New state:

  • witness always triggers an inject into the page leading to a new revision

  • witness is stored in the newly created revision

  • when calculating the verification hash, it takes the witness verification hash as input as well

  • the witness publisher should not write a new revision if the latest revision already has a witness event for the network the witness event was published to.

    • Older witness events are always more valuable then new ones.
    • Mainnet is always more importent then testnet (therefore it writes a new revision if the latest revision was
  • signature is always injected and always leads to a new revision (remove the option)

  • signature is stored alongside the new revision which is created by the inject

  • signature verification hash is used by calculating the verification hash of the newly created revision

@FantasticoFox
Copy link
Collaborator Author

Please review the open fixes required in the PR

@FantasticoFox
Copy link
Collaborator Author

Closed with f947e40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant