Fix DSSE Signature KeyID compatiblity with Sigstore signatures #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using sigstore to sign some metadata, a key ID isn't part of the resulting date. Archivista cannot handle it on upload, getting a key id length error when it's blank. The DSSE specification allows key id to be blank. closes in-toto#321 Signed-off-by: Kairo Araujo <[email protected]>
Signed-off-by: Kairo Araujo <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #362 +/- ##
==========================================
- Coverage 82.40% 1.62% -80.78%
==========================================
Files 10 120 +110
Lines 358 28845 +28487
==========================================
+ Hits 295 468 +173
- Misses 43 28320 +28277
- Partials 20 57 +37 ☔ View full report in Codecov by Sentry. |
jkjell
approved these changes
Aug 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Using sigstore to sign some metadata, a key ID isn't part of the resulting date.
Archivista cannot handle it on upload, getting a key id length error when it's blank.
The DSSE specification allows key id to be blank.
Fixes #321
Acceptance Criteria Met
Special notes for your reviewer:
The last commit is only auto-generated code.