Add config options for http read and write timeouts #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkjell
force-pushed
the
allow-http-timeout-config
branch
from
0d8f81f
to
07bc856
Compare
Signed-off-by: John Kjell <[email protected]>
jkjell
force-pushed
the
allow-http-timeout-config
branch
from
07bc856
to
29b17be
Compare
kairoaraujo
approved these changes
Aug 1, 2024
I don't have any suggestions right now, but if we think good, we could file an issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Fixes issue with large attestation uploads timing out. Also, tests on my local system are failing due to the error message being return as
connection resetinstead ofconnection refused. Happy to change to a stricter comparison if you have a suggestion on how to check for either error mesage.