Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow envFrom for specifying environment variables from configmap/secrets #326

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

ericwyles
Copy link
Contributor

Enhances the helm chart to support envFrom in addition to env. This allows users to have the archivista environment variables in an existing configmap or secret and let kubernetes load them to the deployment through envFrom.

What this PR does / why we need it

This allows use of secrets for configuring connections and also allows for operators that configure db user/pw at deploy time to be able to supply secrets containing the connection information.

Acceptance Criteria Met

  • Docs changes if needed
  • Testing changes if needed
  • All workflow checks passing (automatically enforced)
  • All review conversations resolved (automatically enforced)
  • DCO Sign-off

Special notes for your reviewer:

Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 1.62%. Comparing base (a035c62) to head (6dcbc06).
Report is 120 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #326       +/-   ##
==========================================
- Coverage   82.40%   1.62%   -80.78%     
==========================================
  Files          10     120      +110     
  Lines         358   28856    +28498     
==========================================
+ Hits          295     470      +175     
- Misses         43   28329    +28286     
- Partials       20      57       +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@colek42 colek42 merged commit ea313cd into in-toto:main Jul 9, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants