Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move script tag to <head> #160

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Move script tag to <head> #160

wants to merge 1 commit into from

Conversation

alexgarrettsmith
Copy link

To be fully compliant with PWA web apps (progressive).

Copy link

@xleelz xleelz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CrossEye
Copy link

Please, please, please don't merge this!

We've bet our $3.5 billion business1 on the current design. Changing this now will cost us tons of rework and delay shipping by yet another two years. And I don't think my partner can make it on Ramen noodles that long.

Besides, as PWAs start to fade and the Next Big Thing takes over (sorry no details on this until after our IPO -- our angel investor [Bobby's second cousin] insists), we will just have to move these script tags right back to the body. There's simply no upside.

So please consider the poor working Joe's when you look at something like this. We are trying to become non-working Joseph's, and you're throwing unnecessary roadblocks into our path.

If you do insist on doing this, my brother's girlfriend is an assistant paralegal, and we might just have to take action...


1 Well, not quite yet. We're not yet profitable, not have we actually shipped our product yet, but our business plan looks spiffy; both of our mothers agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants