ast-exporter: use major, not full, version for clang resource dir #1075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
on my (Arch) Clang 17 installation there is no directory named the full version number in /usr/lib/clang I don't know if this is better guaranteed but it seems on Donna we have directories there named after both major and entire version numbers for Clangs 11-14, so using only major seems the safest bet hopefully if this is a mistake CI will notice
fw-immunant
force-pushed
the
fw/fix-resource-dir
branch
from
2efae0d
to
e87ca96
Compare
|
It looks like this is an upstream change as of Clang 17: https://reviews.llvm.org/D125860 |
kkysen
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this patch, running
c2rust-transpilebuilt against Clang 17 produces errors caused by an inability to locatestddef.h.