analyze: track reasons why functions are not rewritten #1072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spernsteiner
force-pushed
the
analyze-dont-rewrite-reasons
branch
from
0c59d70
to
e0cdb2e
Compare
|
@fw-immunant @ahomescu Can one of you take a look at this? #1073 is approved but can't be merged yet because it's based on this PR (and would be nontrivial to rebase off of it) |
|
I'll review today, I was sick most of the week. |
fw-immunant
reviewed
Apr 12, 2024
fw-immunant
reviewed
Apr 12, 2024
fw-immunant
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch replaces most of the existing
fns_failed/fns_fixedmachinery with a new strategy for marking items with a "don't rewrite" flag. This makes it easier to integrate new, stricter checks for unsupported code patterns, with the goal of reducing compile errors in the rewritten code. Some of these checks are also implemented in this branch, such as a check for complex (and currently unsupported)Cellrewrites.When an item is marked as don't-rewrite, we also record a reason flag. This is helpful for debugging, and will also make it easy in the future to disable specific checks (by ignoring the corresponding reason flag) for debugging/testing purposes or by user request.