Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finalizing OptiMaFlow Documentation #127

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Finalizing OptiMaFlow Documentation #127

merged 2 commits into from
Oct 13, 2023

Conversation

janagoe
Copy link
Member

@janagoe janagoe commented Oct 4, 2023 •
edited
Loading

Proposed Changes

Writing documentation on the material flow and finalizing OptiMaFlow.

Definition of Done (optional)

  • Feature is implemented
  • No known bugs that stops the correct execution
  • CI / CD pipeline passed
  • The code guidelines were followed
  • Unit and / or Integration tests for the new feature
  • New feature was added to the documentation

@janagoe janagoe self-assigned this Oct 4, 2023
@janagoe janagoe added the docs Improvements or additions to documentation label Oct 4, 2023
ltoenning
ltoenning previously approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@ltoenning ltoenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"cyber space" is sometimes written with and without hyphen. Maybe this should be unified.

@ltoenning ltoenning dismissed their stale review October 9, 2023 08:22

PR now contains a merge commit.

@janagoe janagoe merged commit 300b454 into iml130:main Oct 13, 2023
5 checks passed
@janagoe janagoe deleted the docs/optimaflow branch October 13, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ltoenning ltoenning ltoenning approved these changes

Assignees

@janagoe janagoe

Labels
docs Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janagoe @ltoenning