Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ns3::Time for time values in scenariofile #116

Merged
merged 2 commits into from
Sep 21, 2023

Conversation

ltoenning
Copy link
Member

@ltoenning ltoenning commented Sep 18, 2023

Related to #55.

Proposed Changes

Use the parsing capability of ns3::Time to read time values with a unit from the scenariofile like "5s".

Updated documentation for default_delay and stop_time will follow when switching completely to the new scenariofile parser.

Definition of Done (optional)

  • Feature is implemented
  • No known bugs that stops the correct execution
  • CI / CD pipeline passed
  • The code guidelines were followed
  • [ ] Unit and / or Integration tests for the new feature
  • New feature was added to the documentation

@ltoenning ltoenning self-assigned this Sep 18, 2023
Copy link
Member

@janagoe janagoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice workaround while we are not able to use the unit libraries yet. However, I would like to use seconds as much as possible in the scenario files. Milliseconds becomes rather unreadable with many zeros.

daisi/utils/ci_scenario_files/minhcast_test.yml Outdated Show resolved Hide resolved
daisi/utils/ci_scenario_files/minhton_cases.yml Outdated Show resolved Hide resolved
daisi/utils/ci_scenario_files/minhton_cases.yml Outdated Show resolved Hide resolved
daisi/utils/ci_scenario_files/minhton_test.yml Outdated Show resolved Hide resolved
daisi/utils/ci_scenario_files/minhton_test.yml Outdated Show resolved Hide resolved
docs/daisi/minhton-ns3/scenariofile.md Outdated Show resolved Hide resolved
docs/daisi/minhton-ns3/scenariofile.md Outdated Show resolved Hide resolved
docs/daisi/minhton-ns3/scenariofile.md Outdated Show resolved Hide resolved
docs/daisi/minhton-ns3/scenariofile.md Outdated Show resolved Hide resolved
daisi/src/manager/scenariofile_component.h Outdated Show resolved Hide resolved
@ltoenning ltoenning merged commit 9c55c16 into iml130:main Sep 21, 2023
5 checks passed
@ltoenning ltoenning deleted the time_units branch September 21, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants