Expose zune-jpeg's Exif chunk extraction #2291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The single failing CI job seems to be unrelated to this change. |
|
In theory PNG and WebP images can have Exif metadata too. Do you want me to make this a method on Update: I went ahead and moved it to the |
This comment was marked as outdated.
This comment was marked as outdated.
|
nvm I figured it out, this works and is ready for review |
This was referenced Jul 27, 2024
fintelia
approved these changes
Aug 26, 2024
There was a problem hiding this comment.
Looks good to me. The image-webp crate also already supports this functionality.
|
Nice! I'll try to add that later, but I'd appreciate a merge of this as-is so that the PR doesn't stall. |
This was referenced Sep 13, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Carbon copy of the ICC chunk handling, but for Exif.
Required for
wondermagickso that we could rotate the JPEGs correctly based on metadata.In the long term we probably want to integrate
kamadak-exif, since it doesn't have any unsafe code and seems to be in quite a good shape. But this PR seems like a simple and uncontroversial start.