Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes some lossy extended WebP issues #1721

Merged
merged 3 commits into from
Jun 6, 2022
Merged

Fixes some lossy extended WebP issues #1721

merged 3 commits into from
Jun 6, 2022

Conversation

tristanphease
Copy link
Contributor

There were two errors with the implementation with the extended WebP images that affected lossy(VP8) WebP images without alpha

  1. Tried to read the VP8 chunk header twice
  2. Tried to fill a rgbaimage buffer with rgbimage size

This PR fixes those issues, so the image in #1712 is decoded successfully.

HeroicKatora
HeroicKatora approved these changes Jun 6, 2022
View reviewed changes
Copy link
Member

@HeroicKatora HeroicKatora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 with rustfmt fixed

@tristanphease
Copy link
Contributor Author

Oops, sorry.
rustfmt run now.

@HeroicKatora HeroicKatora merged commit 1bf6956 into image-rs:master Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeroicKatora HeroicKatora HeroicKatora approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tristanphease @HeroicKatora