Fix build on aarch64 #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ash::vk::ApplicationInfo` [1] actually uses `*const c_char` as a type for its string fields, and the underlying type of `libc::c_char` varies on different architectures. Because of this, the application currently builds fine on x64 (where `c_char` is `i8`) but fails on aarch64 (where `c_char` is `u8` instead). [1]: https://docs.rs/ash/latest/ash/vk/struct.ApplicationInfo.html
mfrischknecht
added a commit
to mfrischknecht/nixpkgs
that referenced
this pull request
Dec 22, 2023
`vulkan-helper` constructs a C string using an explicit `*const i8` pointer, which isn't correct for all architectures. While this builds fine for x64, on aarch64 `c_char` is defined as `u8`, causing compilation errors. This change introduces a patch for this issue I have submitted as an upstream PR [1] until said PR is hopefully accepted. [1]: imLinguin/vulkan-helper-rs#3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ash::vk::ApplicationInfo1 actually uses*const c_charas a type for its string fields, and the underlying type oflibc::c_charvaries on different architectures.Because of this, the application currently builds fine on x64 (where
c_charisi8) but fails on aarch64 (wherec_charisu8instead).Footnotes
https://docs.rs/ash/latest/ash/vk/struct.ApplicationInfo.html ↩