Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

m-to-n restart (new) #1057

Merged
merged 69 commits into from
Aug 28, 2024
Merged

m-to-n restart (new) #1057

merged 69 commits into from
Aug 28, 2024

Conversation

MTCam
Copy link
Member

@MTCam MTCam commented Aug 22, 2024

Overrides #973 to add m-to-n restart capabilities

Adds:

  • bin/meshdist.py: utility for partitioning gmsh-format meshes into rank-specific pkl files, and creates some partition mapping files needed by bin/redist.py
  • bin/redist.py: reads mirgecom restart files and mapping files created by meshdist.py to create a new restart dataset for a different partitioning.
  • bin/mapdecomp.py: Diagnostic tool that discovers a bunch of stuff about a given partitioning, like how many rank/part neighbors each rank/part has
  • some documentation

Modifes:

  • simutil.py: Adds pkl file-based partitioning, arbitrary M reader ranks - to - N writer ranks partitioning (like node-local partitioning)
  • restart.py: Adds utils for mapping data from m-to-n partitionings, and m-to-n restart
  • test_resetart.py: Adds some tests for addded utils (with required data)

Questions for the review:

  • Is the scope and purpose of the PR clear?
    • The PR should have a description.
    • The PR should have a guide if needed (e.g., an ordering).
  • Is every top-level method and class documented? Are things that should be documented actually so?
  • Is the interface understandable? (I.e. can someone figure out what stuff does?) Is it well-defined?
  • Does the implementation do what the docstring claims?
  • Is everything that is implemented covered by tests?
  • Do you see any immediate risks or performance disadvantages with the design? Example: what do interface normals attach to?

MTCam and others added 30 commits September 7, 2023 06:10
@MTCam MTCam marked this pull request as ready for review August 28, 2024 12:41
Copy link
Contributor

@anderson2981 anderson2981 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent. Nice documentation

@MTCam MTCam enabled auto-merge (squash) August 28, 2024 15:01
@MTCam MTCam merged commit 506d27f into main Aug 28, 2024
11 of 13 checks passed
@MTCam MTCam deleted the m-to-n-restart-update branch August 28, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants