Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow us to specify multiple configurations and config per role #120

Merged
merged 10 commits into from
Oct 12, 2024

Conversation

ilijamt
Copy link
Owner

@ilijamt ilijamt commented Oct 12, 2024

No description provided.

Copy link

codecov bot commented Oct 12, 2024

Codecov Report

Attention: Patch coverage is 97.05882% with 4 lines in your changes missing coverage. Please review.

Project coverage is 95.08%. Comparing base (09378e6) to head (a427104).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
path_config_rotate.go 85.71% 0 Missing and 2 partials ⚠️
backend.go 97.22% 1 Missing ⚠️
path_role.go 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #120      +/-   ##
==========================================
+ Coverage   94.25%   95.08%   +0.83%     
==========================================
  Files          18       19       +1     
  Lines        1271     1323      +52     
==========================================
+ Hits         1198     1258      +60     
+ Misses         42       38       -4     
+ Partials       31       27       -4     
Flag Coverage Δ
unittests 95.08% <97.05%> (+0.83%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ilijamt ilijamt merged commit 2747f87 into main Oct 12, 2024
6 checks passed
@ilijamt ilijamt deleted the allow-multiple-configs branch October 12, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant