-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration of LPdiag tool #704
Commits on Nov 24, 2023
-
Please find the original repo at https://github.com/marek-iiasa/MCA/tree/master Note that e.g. the reading material has not yet been included here
Configuration menu - View commit details
-
Copy full SHA for 9797a99 - Browse repository at this point
Copy the full SHA 9797a99View commit details -
Counter of coeffs having different magnitudes was added. Order and wordings of printouts was improved. Comments added to the code, including modified TODO comments.
Configuration menu - View commit details
-
Copy full SHA for c05ba51 - Browse repository at this point
Copy the full SHA c05ba51View commit details -
Move lp_diag files to better locations
* Move README.textile to doc/tools/lp_diag_README.textile for now * This needs to be converted to rst later on
Configuration menu - View commit details
-
Copy full SHA for 7fea85e - Browse repository at this point
Copy the full SHA 7fea85eView commit details -
[lp_diag] Add several features
Counters of outliers added. Order of printouts improved, wording in printouts improved, comments in the core improved, including updated TODOs, which summarize possible further enhancements.
Configuration menu - View commit details
-
Copy full SHA for 6981156 - Browse repository at this point
Copy the full SHA 6981156View commit details -
to reflect the new location of the tool
Configuration menu - View commit details
-
Copy full SHA for 3a3a4e9 - Browse repository at this point
Copy the full SHA 3a3a4e9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 65d00c4 - Browse repository at this point
Copy the full SHA 65d00c4View commit details -
The doc/tools/lp_diag_README.textile contains a brief description of the tool.
Configuration menu - View commit details
-
Copy full SHA for b1ac60d - Browse repository at this point
Copy the full SHA b1ac60dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8a7f080 - Browse repository at this point
Copy the full SHA 8a7f080View commit details -
Configuration menu - View commit details
-
Copy full SHA for c7ecebd - Browse repository at this point
Copy the full SHA c7ecebdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3c63dbe - Browse repository at this point
Copy the full SHA 3c63dbeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a4765e - Browse repository at this point
Copy the full SHA 2a4765eView commit details -
Avoid overwriting cli args passed to the script
Set some rather arbitrary defaults for the args, please change them as necessary. Uncomment later lines (~80) to retain old behaviour.
Configuration menu - View commit details
-
Copy full SHA for 1f61d0f - Browse repository at this point
Copy the full SHA 1f61d0fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1f64fbb - Browse repository at this point
Copy the full SHA 1f64fbbView commit details -
Configuration menu - View commit details
-
Copy full SHA for df55828 - Browse repository at this point
Copy the full SHA df55828View commit details -
Configuration menu - View commit details
-
Copy full SHA for eebaa46 - Browse repository at this point
Copy the full SHA eebaa46View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1186320 - Browse repository at this point
Copy the full SHA 1186320View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1b3f2a2 - Browse repository at this point
Copy the full SHA 1b3f2a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for fe1fbea - Browse repository at this point
Copy the full SHA fe1fbeaView commit details -
to refrain from committing working dirs and *.swp files
Configuration menu - View commit details
-
Copy full SHA for e71517b - Browse repository at this point
Copy the full SHA e71517bView commit details -
Processing of each MPS section organized into the corresponding functions. Thus the, previously large and complex rd_mps() is now compact and much simpler.
Configuration menu - View commit details
-
Copy full SHA for 00616a3 - Browse repository at this point
Copy the full SHA 00616a3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 421f884 - Browse repository at this point
Copy the full SHA 421f884View commit details -
[lp_diag] Reduce complexity to satisfy flake8
lpdiag.py modified substantially in order to conform to the complexity limit of flake8. The new version was checked with flake8 and run through black
Configuration menu - View commit details
-
Copy full SHA for c65931f - Browse repository at this point
Copy the full SHA c65931fView commit details -
main.py modified to ease running it locally (without message_ix env) and fast testing. The committed version is prepared for running in message_ix env.
Configuration menu - View commit details
-
Copy full SHA for 3d96563 - Browse repository at this point
Copy the full SHA 3d96563View commit details -
[lp_diag] Satisfy mypy per fn_out, f_out
main.py: corrected the defaults for fn_out, f_out (inconsistency of types detected by mypy) lpdiag.py: removed duplicated defs of sections[]
Configuration menu - View commit details
-
Copy full SHA for e8d4ae5 - Browse repository at this point
Copy the full SHA e8d4ae5View commit details -
[lp_diag] Satisfy mypy & pycharm in main.py
in main.py, only to satisfy diagnostics of both mypy and pycharm
Configuration menu - View commit details
-
Copy full SHA for 3bb81d5 - Browse repository at this point
Copy the full SHA 3bb81d5View commit details -
[lp_diag] Add initial draft of docs
Far from worth to read, committed as a back-up only.
Configuration menu - View commit details
-
Copy full SHA for f1a9ec2 - Browse repository at this point
Copy the full SHA f1a9ec2View commit details -
[lp_diag] Diverse improvements
This is an intermediate working version. Please wait with comments until a stable version will be committed.
Configuration menu - View commit details
-
Copy full SHA for c6f0808 - Browse repository at this point
Copy the full SHA c6f0808View commit details -
[lp_diag] Change location of test-mps files
The new location simplifies the access.
Configuration menu - View commit details
-
Copy full SHA for d448604 - Browse repository at this point
Copy the full SHA d448604View commit details -
[lp_diag] Refactor and improveme
The file names changed in order to provide a clearer use. CL options changed also to improve usage. Info on actual working directory added, as well as check of readability of the required MPS file. The default run (i.e., without the CL params) uses one of small test MPS. Moreover, a number of improvements in comments, including removal of redundant comments.
Configuration menu - View commit details
-
Copy full SHA for 1237431 - Browse repository at this point
Copy the full SHA 1237431View commit details -
Comments shorten to conform to the line-length limit
Configuration menu - View commit details
-
Copy full SHA for 0b0229d - Browse repository at this point
Copy the full SHA 0b0229dView commit details -
[lp_diag] Sort import statements
To please the (really picky) isort test of lint.
Configuration menu - View commit details
-
Copy full SHA for cba978d - Browse repository at this point
Copy the full SHA cba978dView commit details -
[lp_diag] Improve work-dir diagnostics
Diagnostics of possible problems with wrong working directory improved, as well as the corresponding tip on dealing with the problem.
Configuration menu - View commit details
-
Copy full SHA for 8ca4457 - Browse repository at this point
Copy the full SHA 8ca4457View commit details -
[lp_diag] Add to message_ix/cli.py
I 've added two lines (10 and 158) trying to make it possible to run lpdiag from the CL. Note: lpdiag.py is the main function of lpdiag. This does not work; therefore both lines are commented in order to not cause possible problems.
Configuration menu - View commit details
-
Copy full SHA for cd2c57c - Browse repository at this point
Copy the full SHA cd2c57cView commit details -
[lp_diag] Modify message_ix/cli.py
Uncomment import message_ix.tools.lp_diag.lpdiag and added: main.add_command(message_ix.tools.lp_diag.lpdiag)
Configuration menu - View commit details
-
Copy full SHA for 0cdb467 - Browse repository at this point
Copy the full SHA 0cdb467View commit details -
[lp_diag] Comment pieces of message_ix/cli.py
The commented pieces were attempts to make lpdiag callable in message-ix env, from any place. These don't work with the current set-up of lpdiag.
Configuration menu - View commit details
-
Copy full SHA for 011407c - Browse repository at this point
Copy the full SHA 011407cView commit details -
Correct typos in output generation
Several typos in the text generated during the execution were corrected.
Configuration menu - View commit details
-
Copy full SHA for 637cf26 - Browse repository at this point
Copy the full SHA 637cf26View commit details -
[lp_diag] First complete version of the doc embedded in the message-i…
…x doc Posted as the Readme.rst located in message-ix/message-ix/tools/lp_diag directory, and linked to the message-ix/doc/tools/lp_diag.rst; thus it is embedded in the message-ix doc.
Configuration menu - View commit details
-
Copy full SHA for dd434f1 - Browse repository at this point
Copy the full SHA dd434f1View commit details -
[lp_diag] Correct spelling in doc
Spelling corrected in Readme.rst.
Configuration menu - View commit details
-
Copy full SHA for 4df0b37 - Browse repository at this point
Copy the full SHA 4df0b37View commit details -
Corrected in the text of diagnostics message..
Configuration menu - View commit details
-
Copy full SHA for 70c49b8 - Browse repository at this point
Copy the full SHA 70c49b8View commit details -
[lp_diag] Reformat to satisfy black
To conform to the black test, which failed after adding a single space.
Configuration menu - View commit details
-
Copy full SHA for 929a9b3 - Browse repository at this point
Copy the full SHA 929a9b3View commit details -
Just to please the new version (thus more picky) version of flake8; no changes in the functionality.
Configuration menu - View commit details
-
Copy full SHA for d2227d7 - Browse repository at this point
Copy the full SHA d2227d7View commit details -
Configuration menu - View commit details
-
Copy full SHA for fbe04f0 - Browse repository at this point
Copy the full SHA fbe04f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d78269 - Browse repository at this point
Copy the full SHA 0d78269View commit details -
Configuration menu - View commit details
-
Copy full SHA for 82c94a6 - Browse repository at this point
Copy the full SHA 82c94a6View commit details -
Configuration menu - View commit details
-
Copy full SHA for faf1f63 - Browse repository at this point
Copy the full SHA faf1f63View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5c24d98 - Browse repository at this point
Copy the full SHA 5c24d98View commit details -
Configuration menu - View commit details
-
Copy full SHA for 841ef96 - Browse repository at this point
Copy the full SHA 841ef96View commit details -
* Add test coverage * Add some type hints * Clarify function names * Remove some outdated comments
Configuration menu - View commit details
-
Copy full SHA for fd96495 - Browse repository at this point
Copy the full SHA fd96495View commit details -
Satisfy mypy by renaming variables
Re-enable pre-commit mypy hook.
Configuration menu - View commit details
-
Copy full SHA for ce27097 - Browse repository at this point
Copy the full SHA ce27097View commit details -
Configuration menu - View commit details
-
Copy full SHA for c0a8a2f - Browse repository at this point
Copy the full SHA c0a8a2fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 84ab118 - Browse repository at this point
Copy the full SHA 84ab118View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3780215 - Browse repository at this point
Copy the full SHA 3780215View commit details -
Configuration menu - View commit details
-
Copy full SHA for e48cf16 - Browse repository at this point
Copy the full SHA e48cf16View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5d14049 - Browse repository at this point
Copy the full SHA 5d14049View commit details -
Consolidate LPdiag .gitignore at top level
* Remove the markers: * message_ix/tools/lp_diag/data/mps/of_* * message_ix/tools/lp_diag/Bak/ * message_ix/tools/lp_diag/doc/ * message_ix/tools/lp_diag/sph/ * Use .git/info/exclude for such personal markers!
Configuration menu - View commit details
-
Copy full SHA for 7e49e61 - Browse repository at this point
Copy the full SHA 7e49e61View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4b255de - Browse repository at this point
Copy the full SHA 4b255deView commit details -
Configuration menu - View commit details
-
Copy full SHA for 802af83 - Browse repository at this point
Copy the full SHA 802af83View commit details -
Update lp_diag.py to correctly identify columns
* Changing `"col":self.mat_row` to `"col":self.mat_col` when generating self.mat DataFrame to allow the tool to correctly identify columns with bad coefficients * Thanks, @ywpratama
Configuration menu - View commit details
-
Copy full SHA for 82d3ba6 - Browse repository at this point
Copy the full SHA 82d3ba6View commit details -
Configuration menu - View commit details
-
Copy full SHA for e75a081 - Browse repository at this point
Copy the full SHA e75a081View commit details -
Configuration menu - View commit details
-
Copy full SHA for cc3435f - Browse repository at this point
Copy the full SHA cc3435fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 922fa6e - Browse repository at this point
Copy the full SHA 922fa6eView commit details -
Configuration menu - View commit details
-
Copy full SHA for f292aae - Browse repository at this point
Copy the full SHA f292aaeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1bfce5c - Browse repository at this point
Copy the full SHA 1bfce5cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 12b2c73 - Browse repository at this point
Copy the full SHA 12b2c73View commit details -
Configuration menu - View commit details
-
Copy full SHA for daeccb2 - Browse repository at this point
Copy the full SHA daeccb2View commit details -
Convert lp_diag.cli.main to a click.Command
- Integrate with top-level CLI as "message-ix lp-diag". - Use click option processing; remove read_args(). - Use click.Path and pathlib for checks. - Reflow comments and code for readability.
Configuration menu - View commit details
-
Copy full SHA for f17f727 - Browse repository at this point
Copy the full SHA f17f727View commit details -
Apply numpydoc style to docstrings in .lp_diag
- Fix typos in some string literals.
Configuration menu - View commit details
-
Copy full SHA for deb771a - Browse repository at this point
Copy the full SHA deb771aView commit details -
Add § "API reference" to doc/tools/lp_diag
- Use heading order (*, =, -) consistent with other docs. - Correct a malformed reference. - Add a `.. contents::` directive.
Configuration menu - View commit details
-
Copy full SHA for 1e688f5 - Browse repository at this point
Copy the full SHA 1e688f5View commit details -
Un-hard-wrap lines in doc/tools/lp_diag.rst
Also: - Replace "python lp_diag.py" with "message-ix lp-diag". - use :program: role to document CLI options; use lower case to match the actual option names. - use :file: role where appropriate - Remove comments in cli.py that duplicated docs text.
Configuration menu - View commit details
-
Copy full SHA for 46e5e07 - Browse repository at this point
Copy the full SHA 46e5e07View commit details -
Configuration menu - View commit details
-
Copy full SHA for 51fdfa3 - Browse repository at this point
Copy the full SHA 51fdfa3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 50dce2a - Browse repository at this point
Copy the full SHA 50dce2aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a6c423 - Browse repository at this point
Copy the full SHA 2a6c423View commit details