-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reconfigure usage of technology modules in tools.costs
#221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
measrainsey
force-pushed
the
costs/new-inputs
branch
from
September 2, 2024 11:43
b3af303
to
f3d379a
Compare
measrainsey
force-pushed
the
costs/reconfig-modules
branch
2 times, most recently
from
September 2, 2024 14:08
670b91e
to
c879f8c
Compare
2 tasks
glatterf42
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, approved assuming the tests pass after the announced rebase :)
measrainsey
force-pushed
the
costs/new-inputs
branch
from
September 11, 2024 08:38
ea6e1c7
to
35a913f
Compare
measrainsey
force-pushed
the
costs/reconfig-modules
branch
2 times, most recently
from
September 11, 2024 09:12
a09f866
to
5d111a3
Compare
measrainsey
force-pushed
the
costs/new-inputs
branch
from
September 11, 2024 09:16
a727124
to
621611d
Compare
measrainsey
force-pushed
the
costs/reconfig-modules
branch
2 times, most recently
from
September 11, 2024 09:35
5c93a60
to
6b6d798
Compare
3 tasks
adrivinca
force-pushed
the
costs/new-inputs
branch
from
September 25, 2024 12:27
621611d
to
faa43b7
Compare
measrainsey
force-pushed
the
costs/new-inputs
branch
from
September 26, 2024 07:54
faa43b7
to
00d4120
Compare
measrainsey
force-pushed
the
costs/reconfig-modules
branch
from
September 26, 2024 07:59
6b6d798
to
7ae6542
Compare
glatterf42
force-pushed
the
costs/new-inputs
branch
from
September 26, 2024 09:24
00d4120
to
1788b18
Compare
measrainsey
force-pushed
the
costs/reconfig-modules
branch
2 times, most recently
from
September 26, 2024 09:41
686e41d
to
6c888d9
Compare
Rounding is causing issues when the base year cost is below 0.5 (such is the case for some cooling technologies). These values are rounded down to 0, which then causes NAs for cost projections.
…if both are specified
khaeru
force-pushed
the
costs/reconfig-modules
branch
from
October 1, 2024 08:23
6c888d9
to
8cad50c
Compare
In cases like these, make `reg_cost_ratio` = 1, so there is no regional differentiation (all costs the same across regions).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #221 +/- ##
=======================================
- Coverage 66.5% 65.5% -1.0%
=======================================
Files 204 204
Lines 15822 15823 +1
=======================================
- Hits 10526 10379 -147
- Misses 5296 5444 +148
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the implementation of technology modules (e.g., "energy", "materials") to be more agnostic to module name
In preparation of adding a module for cooling technologies, I have reconfigured the
tools.costs
code base to be more agnostic to the module name being specified.The main changes are:
first_year.csv
intotech_map.csv
to remove the necessity of thefirst_year.csv
filemodule
name instead ofmaterials
when possibleBecause the
materials
module still requires an additional Intratec dataset, there are still instances where the specificmaterials
module needs to be explicitly mentioned.This PR's branch is derived from the
costs/new-inputs
branch, which is under review in the PR #206. Once that PR is approved and merged, I will rebase this branch onto main.How to review
For @khaeru and/or @glatterf42 : Read the diff and note that the CI checks all pass.
PR checklist