Introduce optimization equation #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glatterf42
force-pushed
the
include/optimization-equation
branch
2 times, most recently
from
7b510d8
to
9dcb186
Compare
glatterf42
force-pushed
the
include/optimization-equation
branch
from
0677fa0
to
8c25ad6
Compare
meksor
approved these changes
Oct 2, 2024
glatterf42
force-pushed
the
include/optimization-equation
branch
from
8c25ad6
to
0ce1557
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the final item of the message data model:
Equation. It comes complete with everything the other items already have and only minor changes toColumnthat are required for this to work.Since this is almost identical to #97, my questions are also very similar:
levels andmarginals doEquations have? At the moment, I'm assuming that everyKey(one row of entries inEquation.data) can have its ownlevelandmarginal, making those two just arbitrary columns inEquation.data(though maybe we could limit them to beingfloats or so).Equations need to getdataadded to them manually via anadd()function? Or is there data sort of filled in automatically by the gdx code? I don't think I remember lots ofequation.create(),equation.add_data()functions from the westeros tutorials.Working on the transport tutorial, I noticed that I had completely forgotten about adding
equations = db.relationship()in theRunDB-table. I have even run migrations for these other PRs, but no error came up. I'm wondering if we even need theserelationship()declarations at all.