Configure TestClient to use internal error handling mechanism
#115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meksor
approved these changes
Sep 26, 2024
glatterf42
commented
Sep 30, 2024
| @@ -16,6 +19,9 @@ | |||
|
|
|||
|
|
|||
| class BaseModel(RootBaseModel, mixins.HasCreationInfo): | |||
| # NOTE: only subclasses storing data actually define this! | |||
There was a problem hiding this comment.
Defining the type here so that I can access BaseModel.DataInvalid in the utils.validate_data() function. This might not be necessary though (we could also just raise OptimizationDataValidationErrors straight from ixmp4.core.exceptions there) and it might be confusing since not all subclasses (like Column) actually define this error (since they don't all store and validate data).
So please confirm this solution is fine or please suggest an alternative.
| @validates("data") | ||
| def validate_data(self, key, data: dict[str, Any]): | ||
| return utils.validate_data( | ||
| key=key, | ||
| host=self, |
There was a problem hiding this comment.
Passing the whole instance at the moment to access both .DataInvalid and __str__, but if we change the way we raise errros in utils.validate_data(), we might also be able to just pass __str__.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted by @meksor in his review of #97 , raising
ValueErrors shouldn't work when working with the REST API. This PR disables this behaviour, so these PRs will need a little reworking and if we missed any such errors before, the checks on this PR will fail and we need some reworking here, too.