Optional dimension filter #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhengp0
reviewed
Jul 18, 2024
zhengp0
reviewed
Jul 18, 2024
src/spxmod/dimension.py
Outdated
| @@ -14,8 +14,9 @@ class Dimension: | |||
|
|
|||
| """ | |||
|
|
|||
| def __init__(self, name: str) -> None: | |||
| def __init__(self, name: str, filter: str | None = None) -> None: | |||
There was a problem hiding this comment.
Thanks very much @kels271828! This is really cool, and it is very flexible. I am a little worry that it will depend on data contains all the necessary columns in query, and before it will only require data has self.name. Spin from this, maybe we can let user instead of providing filter, we can let them provide a reference value. And we remove ref (if any) from the self.span. But this will require to set the location_id to -1 when national_id == location_id. Just an idea, let me know what you think :)
There was a problem hiding this comment.
What if we have a skipna arg? Instead of modifying location_id, we could create a new column in preprocessing specifically for this intercept.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding dimension filter so we can create
location_id*age_midintercepts only wherelocation_id != national_idin onemod model.I tested that the number of variables expected is correct and that it runs. Take a look to make sure my changes make sense!