Fix the penalty calculation for enemy units that can evade the engagement during battle #9229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ment during battle
nogov
reviewed
Oct 22, 2024
| const uint32_t penaltyDist = baseDist + Battle::Board::widthInCells + Battle::Board::heightInCells; | ||
|
|
||
| // Flying unit, even inferior in speed, can move around the entire battlefield and easily evade an engagement | ||
| if ( enemy->isFlying() ) { |
There was a problem hiding this comment.
If a flying unit is slowed, it can't fly over the whole battlefield. Does it make sense to take this into account?
There was a problem hiding this comment.
Hi @nogov you definitely should take a closer look at the implementation of this method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #9225
With this PR:
fheroes2.engine.version_.1.1.2.2024-10-22.23-13-18.mp4