Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Addon into Object Part #9226

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Rename Addon into Object Part #9226

merged 2 commits into from
Oct 23, 2024

Conversation

ihhub
Copy link
Owner

@ihhub ihhub commented Oct 22, 2024

As highlighted in #9217 map tile object related code is a black box for most of developers. This code is very convoluted and hard to read. This pull request does simple renaming of Addon into Object Part to make it easier to read.

Other naming is welcome as well!

@ihhub ihhub added the improvement New feature, request or improvement label Oct 22, 2024
@ihhub ihhub added this to the 1.1.4 milestone Oct 22, 2024
@ihhub ihhub self-assigned this Oct 22, 2024
@ihhub ihhub marked this pull request as draft October 22, 2024 15:05
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

src/fheroes2/gui/interface_gamearea.cpp Show resolved Hide resolved
src/fheroes2/maps/maps_tiles.h Show resolved Hide resolved
Copy link

sonarcloud bot commented Oct 22, 2024

@ihhub ihhub marked this pull request as ready for review October 22, 2024 15:26
Copy link
Collaborator

@Districh-ru Districh-ru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ihhub ihhub merged commit 2806099 into master Oct 23, 2024
21 checks passed
@ihhub ihhub deleted the addon-to-object-part branch October 23, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement New feature, request or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants