Various minor improvements #9218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleg-derevenetz
added
improvement
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ihhub
approved these changes
Oct 24, 2024
|
@oleg-derevenetz , huge thanks for these improvements! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Rand::Queuelogic. The previous logic was weird and did many nonsense, there is a way to do the same much easier and without rewriting the contents of the queue (the whole process can beconst);BagArtifacts::exchangeArtifacts(). Instead of passing bags and heroes separately, this method has been turned intostaticand accepts only exchanging heroes. Also a long-standing TODO regarding saving a slot for a spellbook has been implemented;ArmyandTroop.