-
-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui_button.cpp/.h code clean #9206
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Districh-ru , I left one comment here. Can you please check it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Districh-ru , I left 2 more comments here. Can you please take a look at them?
@Districh-ru , thank you very much for this cleanup! |
This PR updates the
ui_button.cpp
andui_button.h
code:unique_prt
instead ofnew
/delete
;Display & output = Display::instance()
argument and callDisplay::instance()
only when it is needed for render;