Fix virtual scroller for multiple columns with unequal children sizes #9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed that after the latest changes related to calculations for unequal children, the virtual scroller stopped working for multiple columns with unequal children. This is because
i
andj
are not the element indexes but rather the indexes of the groups. This causes only a part of the virtual scroll to render.To fix this, I multiplied
i
andj
byitemsPerWrapGroup
, and now everything seems to work.