Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove System.out debug statements #66

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Conversation

akrherz
Copy link
Member

@akrherz akrherz commented Nov 20, 2023

No description provided.

@akrherz akrherz force-pushed the java17 branch 2 times, most recently from 5d533b2 to d7e9d2d Compare November 20, 2023 16:39
@guusdk
Copy link
Member

guusdk commented Nov 20, 2023

I wouldn't apply this change.

System.out writes to the standard output. It is some kind of debugging statement that's being logged here.

By switching to out, you're invoking JspWriter.out, which will cause the data to be logged as part of the web content that's send to the browser.

I'd just remove the lines completely, or, if you must, use a Logger.

@akrherz akrherz changed the title mnt: workaround System.out usage in jsp + java 17 remove System.out debug statements Nov 20, 2023
@guusdk guusdk merged commit 0447322 into igniterealtime:main Nov 20, 2023
3 checks passed
@akrherz akrherz deleted the java17 branch November 20, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants