Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OF-2884: Fix group user removal when making it admin #2545

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

guusdk
Copy link
Member

@guusdk guusdk commented Oct 1, 2024

When a user of a group is made an 'admin' of the group, its removal from the 'members' group should not cause it to be removed from the group completely.

When a user of a group is made an 'admin' of the group, its removal from the 'members' group should not cause it to be removed from the group completely.
@guusdk guusdk added the backport 4.9 on merge, GHA will generate a PR with these changes against 4.9 branch label Oct 1, 2024
Copy link
Member

@akrherz akrherz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't wrap my mind around the logic in this add() method, but this change seems fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 4.9 on merge, GHA will generate a PR with these changes against 4.9 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants