Remove unused methods since now APIs return objects

lib/whatsapp_sdk/api/business_profile.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 
 require_relative "request"
-require_relative "response"
 require_relative "../resource/business_profile"
 
 module WhatsappSdk

lib/whatsapp_sdk/api/medias.rb

@@ -4,7 +4,6 @@
 require "faraday/multipart"
 
 require_relative "request"
-require_relative "response"
 require_relative '../resource/media_types'
 
 module WhatsappSdk
@@ -102,7 +101,7 @@ def upload(sender_id:, file_path:, type:, headers: {})
           multipart: true
         )
 
-        return Api::Responses::IdResponse.new(response["id"])
+        Api::Responses::IdResponse.new(response["id"])
       end
 
       # Delete a Media by ID.

lib/whatsapp_sdk/api/messages.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 
 require_relative "request"
-require_relative "response"
 
 module WhatsappSdk
   module Api

lib/whatsapp_sdk/api/phone_numbers.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 
 require_relative "request"
-require_relative "response"
 
 module WhatsappSdk
   module Api

lib/whatsapp_sdk/api/responses/generic_error_response.rb

@@ -1,11 +1,9 @@
 # frozen_string_literal: true
 
-require_relative "error_response"
-
 module WhatsappSdk
   module Api
     module Responses
-      class GenericErrorResponse < ErrorResponse
+      class GenericErrorResponse
         attr_reader :code, :subcode, :message, :type, :data, :fbtrace_id
 
         def initialize(response:)
@@ -15,8 +13,6 @@ def initialize(response:)
           @type = response["type"]
           @data = response["data"]
           @fbtrace_id = response["fbtrace_id"]
-
-          super(response: response)
         end
 
         def self.response_error?(response:)

lib/whatsapp_sdk/api/responses/http_response_error.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require_relative "data_response"
-
 module WhatsappSdk
   module Api
     module Responses

lib/whatsapp_sdk/api/responses/id_response.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require_relative "data_response"
-
 module WhatsappSdk
   module Api
     module Responses

lib/whatsapp_sdk/api/responses/pagination_records.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require_relative "data_response"
-
 module WhatsappSdk
   module Api
     module Responses

lib/whatsapp_sdk/api/responses/success_response.rb

@@ -1,29 +1,12 @@
 # frozen_string_literal: true
 
-require_relative "data_response"
-
 module WhatsappSdk
   module Api
     module Responses
-      class SuccessResponse < DataResponse
-        def initialize(response:)
-          @success = response["success"]
-          super(response)
-        end
-
+      class SuccessResponse
         def self.success_response?(response:)
           response["success"] == true
         end
-
-        def self.build_from_response(response:)
-          return unless response["success"]
-
-          new(response: response)
-        end
-
-        def success?
-          @success
-        end
       end
     end
   end

lib/whatsapp_sdk/api/templates.rb

@@ -1,9 +1,6 @@
 # frozen_string_literal: true
 
 require_relative "request"
-require_relative "response"
-require_relative 'responses/success_response'
-require_relative 'responses/generic_error_response'
 require_relative "../resource/languages"
 
 module WhatsappSdk

lib/whatsapp_sdk/resource/business_profile.rb

@@ -9,7 +9,7 @@ class BusinessProfile
       ].freeze
 
       attr_accessor :about, :address, :description, :email, :messaging_product,
-      :profile_picture_url, :vertical, :websites
+                    :profile_picture_url, :vertical, :websites
 
       def self.from_hash(hash)
         business_profile = BusinessProfile.new
@@ -26,14 +26,14 @@ def self.from_hash(hash)
       end
 
       def ==(other)
-        self.about == other.about &&
-          self.address == other.address &&
-          self.description == other.description &&
-          self.email == other.email &&
-          self.messaging_product == other.messaging_product &&
-          self.profile_picture_url == other.profile_picture_url &&
-          self.vertical == other.vertical &&
-          self.websites == other.websites
+        about == other.about &&
+          address == other.address &&
+          description == other.description &&
+          email == other.email &&
+          messaging_product == other.messaging_product &&
+          profile_picture_url == other.profile_picture_url &&
+          vertical == other.vertical &&
+          websites == other.websites
       end
     end
   end

lib/whatsapp_sdk/resource/media.rb

@@ -25,12 +25,12 @@ def self.from_hash(hash)
       end
 
       def ==(other)
-        self.id == other.id &&
-          self.file_size == other.file_size &&
-          self.messaging_product == other.messaging_product &&
-          self.mime_type == other.mime_type &&
-          self.sha256 == other.sha256 &&
-          self.url == other.url
+        id == other.id &&
+          file_size == other.file_size &&
+          messaging_product == other.messaging_product &&
+          mime_type == other.mime_type &&
+          sha256 == other.sha256 &&
+          url == other.url
       end
     end
   end

lib/whatsapp_sdk/resource/phone_number.rb

@@ -3,11 +3,10 @@
 module WhatsappSdk
   module Resource
     class PhoneNumber
-
       attr_accessor :id, :verified_name, :display_phone_number, :quality_rating, :is_pin_enabled,
-      :is_official_business_account, :account_mode, :certificate, :code_verification_status,
-      :eligibility_for_api_business_global_search, :name_status, :new_name_status, :status,
-      :search_visibility, :messaging_limit_tier # , :phone, :wa_id, :type
+                    :is_official_business_account, :account_mode, :certificate, :code_verification_status,
+                    :eligibility_for_api_business_global_search, :name_status, :new_name_status, :status,
+                    :search_visibility, :messaging_limit_tier # , :phone, :wa_id, :type
 
       def self.from_hash(hash)
         phone_number = PhoneNumber.new
@@ -30,23 +29,25 @@ def self.from_hash(hash)
         phone_number
       end
 
+      # rubocop:disable Metrics/PerceivedComplexity
       def ==(other)
-        self.id == other.id &&
-          self.verified_name == other.verified_name &&
-          self.display_phone_number == other.display_phone_number &&
-          self.quality_rating == other.quality_rating &&
-          self.is_pin_enabled == other.is_pin_enabled &&
-          self.is_official_business_account == other.is_official_business_account &&
-          self.account_mode == other.account_mode &&
-          self.certificate == other.certificate &&
-          self.code_verification_status == other.code_verification_status &&
-          self.eligibility_for_api_business_global_search == other.eligibility_for_api_business_global_search &&
-          self.name_status == other.name_status &&
-          self.new_name_status == other.new_name_status &&
-          self.status == other.status &&
-          self.search_visibility == other.search_visibility &&
-          self.messaging_limit_tier == other.messaging_limit_tier
+        id == other.id &&
+          verified_name == other.verified_name &&
+          display_phone_number == other.display_phone_number &&
+          quality_rating == other.quality_rating &&
+          is_pin_enabled == other.is_pin_enabled &&
+          is_official_business_account == other.is_official_business_account &&
+          account_mode == other.account_mode &&
+          certificate == other.certificate &&
+          code_verification_status == other.code_verification_status &&
+          eligibility_for_api_business_global_search == other.eligibility_for_api_business_global_search &&
+          name_status == other.name_status &&
+          new_name_status == other.new_name_status &&
+          status == other.status &&
+          search_visibility == other.search_visibility &&
+          messaging_limit_tier == other.messaging_limit_tier
       end
+      # rubocop:enable Metrics/PerceivedComplexity
     end
   end
 end

lib/whatsapp_sdk/resource/template.rb

@@ -59,12 +59,12 @@ def self.from_hash(hash)
       end
 
       def ==(other)
-        self.id == other.id &&
-          self.status == other.status &&
-          self.category == other.category &&
-          self.language == other.language &&
-          self.name == other.name &&
-          self.components_json == other.components_json
+        id == other.id &&
+          status == other.status &&
+          category == other.category &&
+          language == other.language &&
+          name == other.name &&
+          components_json == other.components_json
       end
     end
   end

test/errors_helper.rb

@@ -16,7 +16,9 @@ def assert_unsupported_request_error(http_method, response, object_id, fb_trace_
     )
   end
 
-  def assert_unsupported_request_error_v2(http_method, object_id, fb_trace_id, error_info, type = "GraphMethodException")
+  def assert_unsupported_request_error_v2(
+    http_method, object_id, fb_trace_id, error_info, type = "GraphMethodException"
+  )
     assert_error_info(
       {
         code: 100,

test/test_helper.rb

@@ -10,7 +10,6 @@
 require "pry-nav"
 require "webmock/minitest"
 require "errors_helper"
-require "api_response_helper"
 require 'vcr'
 
 VCR.configure do |config|

test/whatsapp/api/business_profile_test.rb

@@ -3,12 +3,11 @@
 
 require 'api/business_profile'
 require 'api/client'
-require 'api_response_helper'
+
 module WhatsappSdk
   module Api
     class BusinessProfileTest < Minitest::Test
       include(ErrorsHelper)
-      include(ApiResponseHelper)
 
       def setup
         client = Client.new(ENV.fetch('WHATSAPP_ACCESS_TOKEN', nil))
@@ -72,7 +71,7 @@ def test_update_with_success_response
             websites: ["https://www.google.com"],
             vertical: "EDU"
           }
-          assert_equal(true, @business_profile_api.update(phone_number_id: 107_878_721_936_019, params: params))
+          assert(@business_profile_api.update(phone_number_id: 107_878_721_936_019, params: params))
         end
       end