Use TypeScript (Requires #153) #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lucki
force-pushed
the
use_typescript
branch
2 times, most recently
from
61d7c05
to
fb4520d
Compare
Lucki
force-pushed
the
use_typescript
branch
from
fb4520d
to
b593ab3
Compare
|
Nice PR, don't mind if I fork it :^) |
Lucki
force-pushed
the
use_typescript
branch
2 times, most recently
from
bacb79c
to
dc13f69
Compare
|
@Lucki finally, at the last stage :D ... Please rebase; I'll try to find the time to review during the next week! |
… since blueprint-compiler building had to be done anyway.
* allow requesting multiple images * timer fixes * hover preview fixes Don't fetch more images than needed: Before this always the amount of displays were requested even if not used later on.
Older history entries from gsettings might not yet have a adapter associated. This properly types this and fixes related null checks missing.
Introduces new function to resolve a new random path according to an already resolved path with similar elements. Reference: ifl0w#143 (comment)
* Prefix HOME variable to correctly get the users home path * Prevent whitespace issues by quoting the users home path variable Reference: ifl0w#143 (comment)
…and assume soup figures out throttling on its own to not overload servers.
…replacing the fixed resolution with ratios and minimal resolution
…causing invalid states.
when the dedicated option and the timer are enabled
|
The fix appeared in https://gitlab.gnome.org/GNOME/gnome-shell/-/tags/45.alpha ( |
ifl0w
approved these changes
Jul 23, 2023
package.json
Outdated
Comment on lines
3
to
12
| "@gi-types/adw1": "latest", | ||
| "@gi-types/base-types": "latest", | ||
| "@gi-types/gjs-environment": "latest", | ||
| "@gi-types/gtk4-types": "latest", | ||
| "@gi-types/shell": "latest", | ||
| "@typescript-eslint/eslint-plugin": "latest", | ||
| "@typescript-eslint/parser": "latest", | ||
| "eslint": "latest", | ||
| "eslint-plugin-jsdoc": "latest", | ||
| "typescript": "latest" |
There was a problem hiding this comment.
Honestly, I am not sure if it is a good idea to use "latest" here for all dependencies.&
There was a problem hiding this comment.
Pinned them to the current version
src/utils.ts
Outdated
| @@ -169,8 +169,6 @@ function getMonitorCount(): number { | |||
| // @ts-expect-error | |||
| // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access | |||
| const currentDisplay = global?.display as Meta.Display; | |||
|
|
|||
| // eslint-disable-next-line @typescript-eslint/no-unsafe-call | |||
There was a problem hiding this comment.
Fyi, this kind of commits can easily be avoided by using git commit --amend or alternatively git commit --fixup followed by a git rebase --autosquash <ref>
There was a problem hiding this comment.
I even called it fixup but already pushed and did not want to force push while you're possibly in a review state.
src/wallpaperController.ts
Outdated
Comment on lines
349
to
382
| if (type === 0 || type === 2) { | ||
| // FIXME: These are currently hardcoded for the few available wallpaperManager | ||
| if (wallpaperUri.includes('merged_wallpaper') || wallpaperUri.includes('cli-a') || wallpaperUri.includes('cli-b')) | ||
| // merged wallpapers need mode "spanned" | ||
| backgroundSettings.setString('picture-options', 'spanned'); | ||
| else | ||
| // single wallpapers need mode "zoom" | ||
| backgroundSettings.setString('picture-options', 'zoom'); | ||
|
|
||
| Utils.setPictureUriOfSettingsObject(backgroundSettings, wallpaperUri); | ||
| } | ||
|
|
||
| if (type === 1) { | ||
| // FIXME: These are currently hardcoded for the few available wallpaperManager | ||
| if (wallpaperUri.includes('merged_wallpaper') || wallpaperUri.includes('cli-a') || wallpaperUri.includes('cli-b')) | ||
| // merged wallpapers need mode "spanned" | ||
| screensaverSettings.setString('picture-options', 'spanned'); | ||
| else | ||
| // single wallpapers need mode "zoom" | ||
| screensaverSettings.setString('picture-options', 'zoom'); | ||
|
|
||
| Utils.setPictureUriOfSettingsObject(screensaverSettings, wallpaperUri); | ||
| } | ||
|
|
||
| if (type === 2) { | ||
| // FIXME: These are currently hardcoded for the few available wallpaperManager | ||
| if (wallpaperUri.includes('merged_wallpaper') || wallpaperUri.includes('cli-a') || wallpaperUri.includes('cli-b')) | ||
| // merged wallpapers need mode "spanned" | ||
| screensaverSettings.setString('picture-options', 'spanned'); | ||
| else | ||
| // single wallpapers need mode "zoom" | ||
| screensaverSettings.setString('picture-options', 'zoom'); | ||
|
|
||
| Utils.setPictureUriOfSettingsObject(screensaverSettings, backgroundSettings.getString('picture-uri')); |
There was a problem hiding this comment.
I honestly never saw that showing up anywhere. But the gnome settings app also sets the lockscreen value on wallpaper change so it should show up somewhere?
I don't know if it is actually used anywhere in gnome anymore. It used to show up when locking/unlocking your screen iirc. Now there is always the blurred background I think... 🤷
For some reason Gdk was now unable to get my monitor count.
This stops spoiling the API key in sidecar files when saving an image.
weather → whether
When pausing the timer, locking the screen and unlocking again, I got two new wallpaper in a short amount of time the next time the timer runs. The observer were still active and unpausing activated all still observing timer.
ifl0w
pushed a commit
that referenced
this pull request
Aug 15, 2023
ifl0w
pushed a commit
that referenced
this pull request
Feb 11, 2024
ifl0w
pushed a commit
that referenced
this pull request
Feb 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved everything to TypeScript which will generate to JavaScript. This allows proper tooling like syntax checks, code highlights and docs additionally to type safety. It actually found quite a lot of smaller issues in the current code which are now fixed.
Because of this it's now required to have npm installed for building. I added a GitHub actions workflow which adds a build artifact to each push so easy access to nightly builds without manual building is available: example
One smaller caveat for TypeScript currently is that it can't properly type classes based on
GObject.registerClass(). From what I've read it's currently an ongoing process to migrate this to proper ES6 classes in the GJS team.Additionally, adapter can now request multiple new images at once and a lot of smaller fixes.
This already resolves comments from #141 :
Fun fact: While moving these commits from the other PR the majority of d6b5e6a was lost. I don't know why, I don't know how, but I had to rewrite almost everything.Found the lost commit and inserted at the right place - I hope no other things were lost in the process…