-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decouple preference window from wallpaperController (Requires #141) #144
Conversation
@Lucki would you be so kind to Sorry for the extra effort! |
a43d288
to
6fdd6e5
Compare
All done! GitHub got this correctly and no commit dropping was required. Make sure you visit #141 first! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks agian! This is a very interesting and exciting change! Is it good practice to use gschemas as IPC mechanism, though?
Generally, I'm fine with it and interested in how that works out! Also, a cool side effect is that now the wallpaper change can be triggered from other applications/languages as well!
I only added a small comment.
I honestly don't know but since you already had the observer mechanism in place it wasn't far to this. |
Yeah, let's try and see how this works out! The only thing I want to avoid is accepting some (potentially unsafe) user input via this backend-connection. |
@Lucki Again, could you please rebase the commit? Sorry for that! |
6fdd6e5
to
dc7a997
Compare
There are only simple true/false toggles for:
No user input directly. Hm, strange that this doesn't work automatic. It worked automatic locally and GitHub doesn't even register anything different in the force push… Guess I have to rebase every PR when the previous one is merged then. |
Yeah, exactly; these boolean triggers won't be an issue at all. I just realized that I have to look at all the other schemas in general and see what exactly is stored there and how it is used because I never thought about it a lot. Yeah, the hashes change once it is merged and it is a bit annoying that GH does not recognize this. |
I've decoupled the preferences window from all background activity. The background controller now tracks some gsetting changes to communicate with the preferences window. I'm confident this fixes #135 since there's now only one single
wallpaperController
running.This also fixes #126 - just use your favorite keyboard shortcut manager (like gnomes in settings -> keyboard -> shortcuts -> own shortcuts) to set the variable
request-new-wallpaper
totrue
: